| [2009/12/21 01:53:20] @ Log started by gepetto_ | ||
| [2009/12/21 01:53:20] @ github joined channel #puppet-dev | ||
| [2009/12/21 01:53:20] <github> puppet: Markus Roberts master SHA1-4226e01 | ||
| [2009/12/21 01:53:20] <github> Fix for #2959 (calling exit status on a nil report) | ||
| [2009/12/21 01:53:20] <gepetto_> github: #2959 is http://projects.reductivelabs.com/issues/show/2959 "Puppet - Bug #2959: exit_status called on nil for failed puppet run/ - ReductiveLabs.com" | ||
| [2009/12/21 01:53:21] <github> http://bit.ly/6tp0Zv | ||
| [2009/12/21 01:53:23] @ github left channel #puppet-dev () | ||
| [2009/12/21 01:57:37] @ github joined channel #puppet-dev | ||
| [2009/12/21 01:57:37] <github> puppet: Jesse Wolfe 0.25.x SHA1-0884035 | ||
| [2009/12/21 01:57:37] <github> Fix #2970 spec/unit/provider/ssh_authorized_key/parsed.rb has order dependencies | ||
| [2009/12/21 01:57:37] <gepetto_> github: #2970 is http://projects.reductivelabs.com/issues/show/2970 "Puppet - Bug #2970: spec/unit/provider/ssh_authorized_key/parsed.rb has order dependencies - ReductiveLabs.com" | ||
| [2009/12/21 01:57:38] <github> http://bit.ly/5fk2Jg | ||
| [2009/12/21 01:57:40] <github> puppet: Markus Roberts 0.25.x SHA1-0cb5e7d | ||
| [2009/12/21 01:57:42] <github> Fix for #2943 (Make puppet --apply respect --preferred_serialization_format) | ||
| [2009/12/21 01:57:42] <gepetto_> github: #2943 is http://projects.reductivelabs.com/issues/show/2943 "Puppet - Bug #2943: puppet --apply only suppots PSON - ReductiveLabs.com" | ||
| [2009/12/21 01:57:44] <github> http://bit.ly/4IDab5 | ||
| [2009/12/21 01:57:46] @ github left channel #puppet-dev () | ||
| [2009/12/21 12:34:14] @ lak joined channel #puppet-dev | ||
| [2009/12/21 14:37:15] @ jes5 joined channel #puppet-dev | ||
| [2009/12/21 14:41:55] @ Quit: jes5: Remote closed the connection | ||
| [2009/12/21 14:52:46] @ jes5 joined channel #puppet-dev | ||
| [2009/12/21 14:55:10] @ Quit: lak: | ||
| [2009/12/21 15:15:48] @ Quit: tmz: "leaving" | ||
| [2009/12/21 15:16:50] @ tmz joined channel #puppet-dev | ||
| [2009/12/21 15:41:08] @ lak joined channel #puppet-dev | ||
| [2009/12/21 15:54:21] @ ricky joined channel #puppet-dev | ||
| [2009/12/21 18:27:15] @ Quit: jes5: "Leaving." | ||
| [2009/12/21 18:41:33] <lak> mqr: when you say that the tests all run with no failures, do you mean 0.25.x or master? | ||
| [2009/12/21 18:41:49] <mqr> 0.25.x | ||
| [2009/12/21 18:41:59] <mqr> Though there's been some flux. | ||
| [2009/12/21 18:42:31] <mqr> I uncovered a dubious test (patch in the queue) and James/Jesse have a short list as well | ||
| [2009/12/21 18:42:38] <jamesturnbull> mqr: there are about 3 that fail consistently now | ||
| [2009/12/21 18:42:45] <mqr> I think master has more breakage. | ||
| [2009/12/21 18:42:52] <jamesturnbull> mqr: it does indeed | ||
| [2009/12/21 18:43:02] <mqr> Including the one you pinged me about this morning? | ||
| [2009/12/21 18:43:03] <jamesturnbull> mqr: but will shrink when I merge 0.25.xd I suspect | ||
| [2009/12/21 18:43:14] <jamesturnbull> mqr: nope excluding that one | ||
| [2009/12/21 18:43:59] <mqr> Jesse got the "write mount to disk one" a bit ago | ||
| [2009/12/21 18:44:26] <mqr> Do they have tickets? | ||
| [2009/12/21 18:44:46] <lak> i just got 47 failures :/ | ||
| [2009/12/21 18:44:52] <mqr> Yikes. | ||
| [2009/12/21 18:44:52] <lak> mostly rails, settings, and ssl related | ||
| [2009/12/21 18:45:00] <mqr> *sigh* | ||
| [2009/12/21 18:45:02] <lak> i'm going to add fixes onto this commit list | ||
| [2009/12/21 18:45:31] <mqr> Are they legit or spurious do you think? | ||
| [2009/12/21 18:48:06] <mqr> lak? | ||
| [2009/12/21 18:48:09] <lak> a bit of both - test bugs not real bugs | ||
| [2009/12/21 18:48:29] <lak> e.g., :dbconnections was added to rails but broke most of the tests - 9 failures right there, i think | ||
| [2009/12/21 18:48:37] <lak> and the tests are written in a pretty brittle way | ||
| [2009/12/21 18:48:43] <mqr> yeah | ||
| [2009/12/21 18:49:23] <mqr> the one I broke earlier had needless call order dependency (an expects tree) | ||
| [2009/12/21 18:50:00] <lak> i don't know how these tests ever got accepted | ||
| [2009/12/21 18:50:04] <mqr> It wasn't testing if the code worked, it was testing if it was written a certain way. | ||
| [2009/12/21 18:50:06] <lak> which means i probaly wrote them :/ | ||
| [2009/12/21 18:50:12] <mqr> *laugh* | ||
| [2009/12/21 18:50:36] <lak> ayup | ||
| [2009/12/21 18:50:38] <lak> kind of | ||
| [2009/12/21 18:54:59] <jamesturnbull> lak: the rails one will def. be broken | ||
| [2009/12/21 18:55:02] <jamesturnbull> ones | ||
| [2009/12/21 18:55:08] <lak> in master? | ||
| [2009/12/21 18:55:13] <lak> they won't in a bout five mins | ||
| [2009/12/21 18:55:26] <lak> unless they've already all been fixed in 0.25.x, in which case maybe i'll ignore them | ||
| [2009/12/21 18:55:31] <lak> i'm getting mostly rails and webrick failures | ||
| [2009/12/21 18:55:57] <mqr> lak: was that 47 in master, or in 0.25.x? | ||
| [2009/12/21 18:56:00] <lak> master | ||
| [2009/12/21 18:56:04] <lak> i'm developing code for rowlf | ||
| [2009/12/21 18:56:11] <lak> well, i'm done with the code | ||
| [2009/12/21 18:56:16] <lak> but figured i'd throw in some test fixes, too | ||
| [2009/12/21 18:56:20] <mqr> Oh. Man. You had me going there. | ||
| [2009/12/21 18:56:31] <lak> should i just skip that? | ||
| [2009/12/21 18:57:06] <mqr> Look through the test fixes in 0.25.x (or better yet, let's merge) before we resolve all those. | ||
| [2009/12/21 18:57:56] <mqr> I was thinking you meant there were 47 that we'd missed somehow in 0.25.x, and my faith was trembling. | ||
| [2009/12/21 18:58:15] <lak> sorry :) | ||
| [2009/12/21 18:58:24] <lak> hrm | ||
| [2009/12/21 18:58:34] <lak> test/unit doesn't want to admit that the mocha methods are loaded again :/ | ||
| [2009/12/21 18:58:39] <lak> claims the 'stub' method isn't found | ||
| [2009/12/21 18:58:47] <lak> ok, i'll hold off on those fixes, then | ||
| [2009/12/21 18:58:59] <lak> probably should merge before this code is added, too | ||
| [2009/12/21 19:04:07] <jamesturnbull> mqr: lak this is the most frequent ticket offenders - http://pastie.org/752556 | ||
| [2009/12/21 19:04:31] <jamesturnbull> lak: well feel free to merge now | ||
| [2009/12/21 19:04:36] <lak> ok | ||
| [2009/12/21 19:04:37] <jamesturnbull> lak: seems like a reasonable enough time | ||
| [2009/12/21 19:04:41] <lak> those still haven't been resolved? | ||
| [2009/12/21 19:04:59] <jamesturnbull> lak: we've gone form 9 always broken to 3 in the last week | ||
| [2009/12/21 19:05:04] <lak> ah | ||
| [2009/12/21 19:05:04] <jamesturnbull> from even | ||
| [2009/12/21 19:05:32] <jamesturnbull> aim is 0 failed for .2 | ||
| [2009/12/21 19:06:05] <mqr> I've been trying to reproduce those on and off for the past week. OS X & kubuntu. | ||
| [2009/12/21 19:06:34] <jamesturnbull> mqr: I'm on Fedora if that helps | ||
| [2009/12/21 19:06:36] <mqr> Jesse and I are working a theory on the PID one (race condition) | ||
| [2009/12/21 19:07:08] <mqr> ditto the second | ||
| [2009/12/21 19:08:25] <mqr> The third we've gotten nowhere on (but haven't hit hard yet either) | ||
| [2009/12/21 19:13:24] <lak> the merge was actually pretty simple | ||
| [2009/12/21 19:13:27] <lak> only four files, i think | ||
| [2009/12/21 19:14:30] @ github joined channel #puppet-dev | ||
| [2009/12/21 19:14:30] <github> puppet: Markus Roberts 0.25.x SHA1-5e5c8b5 | ||
| [2009/12/21 19:14:30] <github> Fixing tests | ||
| [2009/12/21 19:14:31] <github> http://bit.ly/5d7nQz | ||
| [2009/12/21 19:14:33] <github> puppet: Jesse Wolfe 0.25.x SHA1-b185801 | ||
| [2009/12/21 19:14:35] <github> Fixing #2960 Test Failed: 'Puppet::Type::Mount::ProviderParsed when modifying the filesystem tab should write the mount to disk when :flush is called | ||
| [2009/12/21 19:14:36] <gepetto_> github: #2960 is http://projects.reductivelabs.com/issues/show/2960 "Puppet - Bug #2960: Test Failed: 'Puppet::Type::Mount::ProviderParsed Puppet::Type::Mount::ProviderParsed when modifying the filesystem tab should write the mount to disk when :flush is called - ReductiveLabs.com" | ||
| [2009/12/21 19:14:38] <github> http://bit.ly/60ByUs | ||
| [2009/12/21 19:14:40] @ github left channel #puppet-dev () | ||
| [2009/12/21 19:15:31] <lak> hrm | ||
| [2009/12/21 19:15:35] <mqr> lak: github heard you. | ||
| [2009/12/21 19:16:00] <lak> i didn't do the merge correctly -- missed one of the patches i needed to fix (2 in the same file) | ||
| [2009/12/21 19:16:03] <mqr> Luke: "I'm merged" Github: "No you're not" | ||
| [2009/12/21 19:16:13] <lak> oh, it's merged, it just doesn't parse | ||
| [2009/12/21 19:16:15] <lak> :/ | ||
| [2009/12/21 19:18:17] <lak> and i've no idea how to use git rebase -i to add squash commits onto a merge commit, so i'm just doing it again | ||
| [2009/12/21 19:18:22] <lak> and this time, running the tests before i merge | ||
| [2009/12/21 19:18:28] <lak> rather, before i commit | ||
| [2009/12/21 19:20:06] <jamesturnbull> and the tree was so clean | ||
| [2009/12/21 19:20:11] <jamesturnbull> damn you lak damn you... :) | ||
| [2009/12/21 19:24:12] <lak> i got 32 test failures | ||
| [2009/12/21 19:24:22] <lak> looks like multiple sets of related failures | ||
| [2009/12/21 19:24:33] <lak> lots of failures related to settings | ||
| [2009/12/21 19:25:23] <lak> nice; jamesturnbull pushed code while i was merging, and now my merge doesn't want to take :/ | ||
| [2009/12/21 19:27:45] <lak> or something | ||
| [2009/12/21 19:27:47] <lak> i've no idea | ||
| [2009/12/21 19:28:03] <jamesturnbull> lak: sorry - didn't realise you were doing it right now | ||
| [2009/12/21 19:28:11] <jamesturnbull> what's happening? | ||
| [2009/12/21 19:28:22] <lak> ok, merged, and pushed to all repos i have access to | ||
| [2009/12/21 19:29:47] <lak> mqr: i'll let you and jesse look through the failures (i got 28 in newly merged master) | ||
| [2009/12/21 19:30:28] <mqr> Ok. After 0.25.2, or do you think there's any that may be lurking in 0.25.x? | ||
| [2009/12/21 19:31:45] <mqr> "jamesturnbull: damn you lak damn you... :)" -- do I hear a new team motto? | ||
| [2009/12/21 19:32:14] <lak> new? | ||
| [2009/12/21 19:32:22] <mqr> *laugh* | ||
| [2009/12/21 19:32:26] <lak> after 0.25.2, i guess | ||
| [2009/12/21 19:32:38] <lak> i might take a crack at some of them, since they look mostly like low-hanging fruit | ||
| [2009/12/21 19:32:43] <mqr> But I don't think you were expecting him to act on it, were you? | ||
| [2009/12/21 19:32:56] <mqr> Sure. | ||
| [2009/12/21 19:47:19] <jamesturnbull> lak: http://www.gnome.org/~michael/blog/copyright-assignment.html | ||
| [2009/12/21 19:47:39] <jamesturnbull> hmm I only get 12 failures in master now | ||
| [2009/12/21 19:47:52] <lak> jamesturnbull: cool, i'll look at it | ||
| [2009/12/21 20:35:07] @ Quit: lak: | ||
| [2009/12/21 21:11:07] @ lak joined channel #puppet-dev | ||
| [2009/12/21 21:50:24] @ Quit: lak: | ||
| [2009/12/21 23:08:06] @ lak joined channel #puppet-dev | ||
| [2009/12/21 23:10:23] @ Quit: lak: Client Quit | ||
| [2009/12/21 23:21:40] @ github joined channel #puppet-dev | ||
| [2009/12/21 23:21:40] <github> puppet: Markus Roberts 0.25.x SHA1-d60ea0e | ||
| [2009/12/21 23:21:40] <github> A slide down the RFC-1123 slope towards MS Windows compatibility and chaos | ||
| [2009/12/21 23:21:41] <github> http://bit.ly/7ppllq | ||
| [2009/12/21 23:21:43] @ github left channel #puppet-dev () | ||
| [2009/12/21 23:43:55] @ lak joined channel #puppet-dev |
Generated by irclog2html.py 2.6 by Marius Gedminas - find it at mg.pov.lt!